Discussion:
[patch] arptables respect LDFLAGS
Peter Volkov
2010-09-15 13:48:53 UTC
Permalink
Hi. The patch in attachment makes arptables respect LDFLAGS. Please,
apply. Thank you.
--
Peter.
Peter Volkov
2010-10-09 13:17:29 UTC
Permalink
Hi again. What is the best way to contact arptables developers? My
previous patch was left without attention, should I resend it? In
attachment there are three fixes from debian:

1. arptables_save patch makes arp_tables don't resolve host names and
don't convert '*' interface names to any. Remove '*' interface names.
2. manpage patch removes old version from man page
3. is a patch from Jeroen van Wolffelaar to make arptables --proto-type
also accept hexadecimal inputs (ethernet protocol numbers are often
specfied in hex, not decimal), using standard strtol() behaviour (hex
iff starts with 0x).

Please, apply.
--
Peter.
Bart De Schuymer
2010-10-09 19:17:57 UTC
Permalink
Hello Peter,

Patch 2 and 3 are committed.
For the '*' part of patch 1 I'd rather remove the -v usage in
arptables-restore. This will require fixing the reason why -v is used in
the first place. I wasn't aware this is due to a bug: the -i and -o
interfaces aren't printed unless -v is specified. I'll look into this.

cheers,
Bart
Post by Peter Volkov
Hi again. What is the best way to contact arptables developers? My
previous patch was left without attention, should I resend it? In
1. arptables_save patch makes arp_tables don't resolve host names and
don't convert '*' interface names to any. Remove '*' interface names.
2. manpage patch removes old version from man page
3. is a patch from Jeroen van Wolffelaar to make arptables --proto-type
also accept hexadecimal inputs (ethernet protocol numbers are often
specfied in hex, not decimal), using standard strtol() behaviour (hex
iff starts with 0x).
Please, apply.
--
Bart De Schuymer
www.artinalgorithms.be

--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to ***@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Peter Volkov
2010-10-14 15:37:32 UTC
Permalink
Hi Bart. Thank you for review/applying patches. Could you also apply
attached patch to fix not respecting LDFLAGS issue (very similar to one
I've sent you long time ago for ebtables :) )

--
Peter.
Post by Bart De Schuymer
Hello Peter,
Patch 2 and 3 are committed.
For the '*' part of patch 1 I'd rather remove the -v usage in
arptables-restore. This will require fixing the reason why -v is used in
the first place. I wasn't aware this is due to a bug: the -i and -o
interfaces aren't printed unless -v is specified. I'll look into this.
cheers,
Bart
Post by Peter Volkov
Hi again. What is the best way to contact arptables developers? My
previous patch was left without attention, should I resend it? In
1. arptables_save patch makes arp_tables don't resolve host names and
don't convert '*' interface names to any. Remove '*' interface names.
2. manpage patch removes old version from man page
3. is a patch from Jeroen van Wolffelaar to make arptables --proto-type
also accept hexadecimal inputs (ethernet protocol numbers are often
specfied in hex, not decimal), using standard strtol() behaviour (hex
iff starts with 0x).
Bart De Schuymer
2010-10-24 17:10:47 UTC
Permalink
Applied.

Thanks,

Bart
Post by Peter Volkov
Hi Bart. Thank you for review/applying patches. Could you also apply
attached patch to fix not respecting LDFLAGS issue (very similar to o=
ne
Post by Peter Volkov
I've sent you long time ago for ebtables :) )
--
Peter.
=D0=92 =D0=A1=D0=B1=D1=82, 09/10/2010 =D0=B2 21:17 +0200, Bart De Sch=
Post by Bart De Schuymer
Hello Peter,
Patch 2 and 3 are committed.
For the '*' part of patch 1 I'd rather remove the -v usage in=20
arptables-restore. This will require fixing the reason why -v is use=
d in=20
Post by Peter Volkov
Post by Bart De Schuymer
the first place. I wasn't aware this is due to a bug: the -i and -o=20
interfaces aren't printed unless -v is specified. I'll look into thi=
s.
Post by Peter Volkov
Post by Bart De Schuymer
cheers,
Bart
Post by Peter Volkov
Hi again. What is the best way to contact arptables developers? My
previous patch was left without attention, should I resend it? In
1. arptables_save patch makes arp_tables don't resolve host names a=
nd
Post by Peter Volkov
Post by Bart De Schuymer
Post by Peter Volkov
don't convert '*' interface names to any. Remove '*' interface name=
s.
Post by Peter Volkov
Post by Bart De Schuymer
Post by Peter Volkov
2. manpage patch removes old version from man page
3. is a patch from Jeroen van Wolffelaar to make arptables --proto-=
type
Post by Peter Volkov
Post by Bart De Schuymer
Post by Peter Volkov
also accept hexadecimal inputs (ethernet protocol numbers are often
specfied in hex, not decimal), using standard strtol() behaviour (h=
ex
Post by Peter Volkov
Post by Bart De Schuymer
Post by Peter Volkov
iff starts with 0x).
--=20
Bart De Schuymer
www.artinalgorithms.be

--
To unsubscribe from this list: send the line "unsubscribe netfilter-dev=
el" in
the body of a message to ***@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Loading...